Remove E731 from ruff ignore by replacing lambda assignments with def - #2817
Merged
KaelanDt merged 2 commits intoMar 26, 2026
Merged
Conversation
ManoBharathi93
requested review from
KaelanDt,
lantiga and
mruberry
as code owners
March 23, 2026 14:46
for more information, see https://pre-commit.ci
Contributor
Author
|
@lantiga , I couldn't able to see the detailed failures !, can you /anyone help me what's broken and where its broken so i can try to fix it |
Contributor
Author
Contributor
|
Hi @ManoBharathi93, thank you for the PR. The test failures were unrelated. |
KaelanDt
approved these changes
Mar 26, 2026
Contributor
Author
Thanks @KaelanDt . I was exploring the Thunder project and was interested in contributing. However, I wasn’t able to connect with the Lightning engineers on Discord, as it seems to be inactive. Is there any other communication channel where I could interact with the team and work on small features? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove E731 from ruff ignore by replacing lambda assignments with def
Part of #2218
Validation for pre-commit:
CC: @Borda